barnett/apaquarium
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

PaintedCreature is badly encapsulated #8

New issue
Open
opened 2016-03-21 08:50:43 +00:00 by btrzcinski · 0 comments
btrzcinski commented 2016-03-21 08:50:43 +00:00 (Migrated from github.com)
Copy link

It uses protected members, like width/height, which are final for no real reason. It doesn't serve as a good academic example of class design.

  • width/height should be encapsulated and modifiable
  • paint should be public, most likely
It uses protected members, like width/height, which are final for no real reason. It doesn't serve as a good academic example of class design. - width/height should be encapsulated and modifiable - paint should be public, most likely
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
develop
gh-pages
No results found.
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
barnett/apaquarium#8
No description provided.